feat: remove product config & clean up#897
Open
maltesander wants to merge 14 commits into
Open
Conversation
adwk67
reviewed
Jun 1, 2026
| # [patch."https://github.com/stackabletech/operator-rs.git"] | ||
| # stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "main" } | ||
| [patch."https://github.com/stackabletech/operator-rs.git"] | ||
| stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "smooth-operator"} |
Member
There was a problem hiding this comment.
TODO: update to new op-rs release (?)
Member
Author
There was a problem hiding this comment.
Yeah but i think we need other operators implemented to check what we can move or have to adapt first. Otherwise well do release after release...
Member
There was a problem hiding this comment.
Yep, this is just a marker so we don't forget
…remove-product-config
16 tasks
adwk67
reviewed
Jun 2, 2026
| # [patch."https://github.com/stackabletech/operator-rs.git"] | ||
| # stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "main" } | ||
| [patch."https://github.com/stackabletech/operator-rs.git"] | ||
| stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "smooth-operator"} |
Member
There was a problem hiding this comment.
Yep, this is just a marker so we don't forget
…operties.rs Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
Member
Replace the hand-rolled Java-properties escaper (rust/operator-binary/src/controller/build/properties/writer.rs) with stackable_operator::v2::config_file_writer (moved there via operator-rs #1217 on the smooth-operator branch). A thin adapter in properties/mod.rs maps trino's String-valued maps onto the writer's Option<String>-valued interface; the kuttl-pinned escape behaviours stay covered by unit tests against the shared writer. Unlike the other operators this is not a pure relocation: the hand-rolled escaper (introduced on this branch, never released) had unintentionally diverged from the product-config writer it replaced. A differential test showed 8 divergences, all unreachable from operator defaults (the kuttl smoke snapshot's 157 property lines are unaffected): - inner/trailing spaces in values: now escaped (read-back identical per the Java properties spec) - tab/newline/CR in values: now escaped (the raw output was malformed) - non-ASCII: now ISO-8859-1-spec behaviour again (error on Latin-1-range values, \uXXXX beyond) instead of raw UTF-8 pass-through This restores the exact serialization behaviour of the released operator, which renders via the identical product-config code. The base dependency tag moves from stackable-operator-0.111.0 to 0.111.1, matching the other operators; cargo only substitutes a [patch] whose package version matches, and the smooth-operator branch carries 0.111.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker